You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI.yml -> This includes building AD, which includes UT and IT plus running multi node integration tests (linux, macos, windows). Windows is seperate here because I was not able to run it correctly with the -Dtest.logs=true option, only on linux and macos, I believe its okay for now as we only need that part for precision and recall and its enough to just see it on those two platforms.
Security-Test-CI.yml -> Assembles AD and sets up docker container to run AD integ tests with security plugin if its available. (Linux only cause no infra set up yet for windows and macos)
Bwc-test-CI.yml -> Runs BWC separately for AD (Linux only cause we don't have an older version with windows and macos)
Additionally it might be hard to notice cause of the new files but I changed some of the parsing logic in security-test-ci as it was failing to parse the correct docker version before.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Security tests are failing here, I think this is a 3.0 specific problem as the same tests passed on this PR for 2.x: #707
The errors are also related to http client which had some changes in 3.0 branch.
If rest of checks pass I believe we should still merge this in, backport the change and open an issue on security to further investigate errors.
Can we rename the workflows to follow a consistent convention? I think all underscore (verb-first) like mentioned here is a good way, or all--. I see our workflows are already a bit inconsistent
backport 2.xinfraChanges to infrastructure, testing, CI/CD, pipelines, etc.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opensearch-trigger-bot
bot
added
backport 2.x
infra
Description
Split our CI into 3 different workflows.
CI.yml -> This includes building AD, which includes UT and IT plus running multi node integration tests (linux, macos, windows). Windows is seperate here because I was not able to run it correctly with the
-Dtest.logs=trueoption, only on linux and macos, I believe its okay for now as we only need that part for precision and recall and its enough to just see it on those two platforms.Security-Test-CI.yml -> Assembles AD and sets up docker container to run AD integ tests with security plugin if its available. (Linux only cause no infra set up yet for windows and macos)
Bwc-test-CI.yml -> Runs BWC separately for AD (Linux only cause we don't have an older version with windows and macos)
Additionally it might be hard to notice cause of the new files but I changed some of the parsing logic in security-test-ci as it was failing to parse the correct docker version before.
Issues Resolved
resolves #275
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.